-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fdc): Updated to allow for sdktype to be set (core vs gen) #13392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
changed the title
Updated to allow for sdktype to be set (core vs gen)
feat(fdc): Updated to allow for sdktype to be set (core vs gen)
Sep 24, 2024
aashishpatil-g
suggested changes
Sep 24, 2024
packages/firebase_data_connect/firebase_data_connect/lib/src/common/common_library.dart
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/lib/src/network/grpc_transport.dart
Outdated
Show resolved
Hide resolved
aashishpatil-g
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending the requested changes.
packages/firebase_data_connect/firebase_data_connect/lib/src/network/grpc_transport.dart
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/lib/src/common/common_library.dart
Show resolved
Hide resolved
cynthiajoan
approved these changes
Sep 24, 2024
russellwheatley
approved these changes
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.